aboutsummaryrefslogtreecommitdiff
path: root/reproduce/software
diff options
context:
space:
mode:
authorMohammad Akhlaghi <mohammad@akhlaghi.org>2020-09-07 19:42:03 +0100
committerMohammad Akhlaghi <mohammad@akhlaghi.org>2020-09-07 19:42:03 +0100
commit6727f84b6d10fe77981b3e8117f436ec1039f643 (patch)
tree6b47ea2922ad00a846cbd79c6d971f761c2bee38 /reproduce/software
parent6d18576568da8298295c82c0853057d7ea5e8b61 (diff)
Software installation: removed IFS statements in pre-make-build.sh
Until a recent commit, the IFS='"' was added at the start of the variables in this shell script and as a result, the SPACE character wasn't being used as a delimiter. This caused a major problem when downloading the tarballs (all the backup servers were considered as the top link). With this commit we removed these 'IFS' statements). Because we now check for the existance of meta-characters in the build directory name, there is no more problem, and also generally both the calling command and internally, we have double-qutations around the variable names. So removal of IFS will not affect the result in this scenario. This bug was found by Mohammadreza Khellat.
Diffstat (limited to 'reproduce/software')
-rwxr-xr-xreproduce/software/shell/pre-make-build.sh8
1 files changed, 4 insertions, 4 deletions
diff --git a/reproduce/software/shell/pre-make-build.sh b/reproduce/software/shell/pre-make-build.sh
index a18966f..f11e6e6 100755
--- a/reproduce/software/shell/pre-make-build.sh
+++ b/reproduce/software/shell/pre-make-build.sh
@@ -31,10 +31,10 @@ set -e
# Input arguments (the 'IFS's are to allow space in the name).
-IFS='"' bdir="$1"
-IFS='"' ddir="$2"
-IFS='"' downloader="$3"
-IFS='"' user_backup_urls="$4"
+bdir="$1"
+ddir="$2"
+downloader="$3"
+user_backup_urls="$4"