diff options
| author | Mohammad Akhlaghi <mohammad@akhlaghi.org> | 2019-08-05 16:08:03 +0100 |
|---|---|---|
| committer | Mohammad Akhlaghi <mohammad@akhlaghi.org> | 2019-08-05 16:10:39 +0100 |
| commit | 29540c2ba572ee46e9907c4b66153ce02b39c701 (patch) | |
| tree | 72238a174edc1ff7566c754f3ae8b49910fd5767 /reproduce/software/make | |
| parent | 33e603d8ef610508045e689e61645da34cc45e2e (diff) | |
WCSLIB needs -lcfitsio on some systems
Until now, we were relying on WCSLIB's internal checking and linking with
CFITSIO. But on one macOS system (not others that had no problem!), we
noticed that it complains with undefined symbol linking errors to CFITSIO
libraries.
With this commit, as a fast/ugly solution, we are explicity adding
`-lcfitsio' to WCSLIB's `LIBS' variable so all binaries are linked with it
automatically. We'll be in touch with the WCSLIB author to see if a better
solution can be found.
Diffstat (limited to 'reproduce/software/make')
| -rw-r--r-- | reproduce/software/make/high-level.mk | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/reproduce/software/make/high-level.mk b/reproduce/software/make/high-level.mk index b8c3997..167f430 100644 --- a/reproduce/software/make/high-level.mk +++ b/reproduce/software/make/high-level.mk @@ -532,10 +532,22 @@ $(ibidir)/libgit2: $(tdir)/libgit2-$(libgit2-version).tar.gz \ fi \ && echo "Libgit2 $(libgit2-version)" > $@ +# LIBS with `-lcfitsio': For some reason WCSLIB 6.3 has some linking +# problems on some versions of macOS, giving the following error: +# +# Undefined symbols for architecture x86_64: +# "_fits_read_wcstab", referenced from: +# _ftwcst_ in getwcstab_f.o +# "_gFitsFiles", referenced from: +# _ftwcst_ in getwcstab_f.o +# ld: symbol(s) not found for architecture x86_64 +# +# For the time being, the best/most-generic solution we found was to +# explicitly force linking with CFITSIO (which happens anyway). $(ibidir)/wcslib: $(tdir)/wcslib-$(wcslib-version).tar.bz2 \ $(ibidir)/cfitsio $(call gbuild, $<, wcslib-$(wcslib-version), , \ - LIBS="-pthread -lcurl -lm" \ + LIBS="-pthread -lcfitsio -lcurl -lm" \ --with-cfitsiolib=$(ildir) \ --with-cfitsioinc=$(idir)/include \ --without-pgplot) \ |