diff options
author | Pedram Ashofteh Ardakani <pedramardakani@gmail.com> | 2020-04-23 17:34:33 +0430 |
---|---|---|
committer | Mohammad Akhlaghi <mohammad@akhlaghi.org> | 2020-04-26 02:46:32 +0100 |
commit | 4d3db9a78fb84f837a0b1665906ce0da1856a3e3 (patch) | |
tree | 99993afa4b43b2814bcf62ee92fdcad330492c97 /reproduce/analysis/make/top-make.mk | |
parent | d73a2628310ce01f98bf07cdf6d5d30ccf807a8a (diff) |
Configure.sh: build directory checked for ability to modify permissions
Until now we only checked for the existance and write-ability of the build
directory. But we recently discovered that if the specified build-directory
is in a non-POSIX compatible partition (for example NTFS), permissions
can't be modified and this can cause crashs in some programs (in
particular, while building Perl, see [1]). The thing that makes this
problem hard to identify is that on such partitions, `chmod' will still
return 0 (so it was hard to find).
With this commit, a check has been added after the user specifies the
build-directory. If the proposed build directory is not able to handle
permissions as expected, the configure script will not continue and will
let the user know and will ask them for another directory.
Also, the two printed characters at the start of error messages were
changed to `**' (instead of `--'). When everything is good, we'll use `--'
to tell the user that their given directory will be used as the build
directory. And since there are multiple checks now, the final message to
specify a new build directory is now moved to the end and not repeated in
every check.
[1] https://savannah.nongnu.org/support/?110220
Diffstat (limited to 'reproduce/analysis/make/top-make.mk')
0 files changed, 0 insertions, 0 deletions