diff options
| author | Boud Roukema <boud@cosmo.torun.pl> | 2025-03-18 18:36:18 +0100 |
|---|---|---|
| committer | Mohammad Akhlaghi <mohammad@akhlaghi.org> | 2025-03-21 17:45:53 +0100 |
| commit | 5cdf92432035d938d61635eba3bcc1b55e48108d (patch) | |
| tree | 7dc3f1f85a11ed692d39dd74f47e2881cbd424d6 | |
| parent | 858ca5fb9038d9901ed1fc489f247aac7b67e569 (diff) | |
Configuration: Python packages can be reinstalled without crash
Summary: this will not affect any analysis.
Until this commit, there were often fatal errors when re-installing a
python package in the Maneage system (after events such as: an error during
the install; a computer reboot; a modification of dependencies or build
rules in 'high-level.mk'; or a removal of the successful-install indicator
file '.local/version-info/python/PACKAGENAME-PACKAGEVERSION'). The reason
for this particular failure was that 'python-installer' considers file
clobbering - replacing an old existing file by a new file - to be a fatal
error; the python function 'FileExistsError' is used to report the error
and terminate execution.
With this commit, the build rule for 'python-installer' comments out the
'FileExistsError' line in 'src/installer/destinations.py'. Based on several
tests of interrupted installs of python packages, it appears that this
commit solves this bug, allowing convenient re-installs of python packages.
| -rw-r--r-- | reproduce/software/make/python.mk | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/reproduce/software/make/python.mk b/reproduce/software/make/python.mk index 871bad7..76fc252 100644 --- a/reproduce/software/make/python.mk +++ b/reproduce/software/make/python.mk @@ -869,9 +869,24 @@ $(ipydir)/python-dateutil-$(python-dateutil-version): \ python-dateutil $(python-dateutil-version), GPEP517) $(ipydir)/python-installer-$(python-installer-version): \ - $(ibidir)/python-$(python-version) + $(ibidir)/python-$(python-version) + +# Prepare the tarball. tarball=python-installer-$(python-installer-version).tar.lz $(call import-source, $(python-installer-url), $(python-installer-checksum)) + +# Modify the line in the source that will cause a crash when a +# to-be-installed file already exists in the installation path. This +# is very important for Python packages in Maneage (when a dependency +# is updated, the package needs to be re-built, but that would cause +# due to this line). + pyhook_before(){ + mv -v src/installer/destinations.py src/installer/destinations.py.orig; \ + sed -e 's/\(raise FileExistsError.message.\)/## \1/' \ + src/installer/destinations.py.orig > src/installer/destinations.py + } + +# Build the Python installer. $(call pybuild, tar -xf, \ python-installer-$(python-installer-version),,, \ BOOT_INSTALLER) |