diff options
authorBoud Roukema <boud@cosmo.torun.pl>2020-07-21 18:01:22 +0200
committerMohammad Akhlaghi <mohammad@akhlaghi.org>2020-07-21 17:30:47 +0100
commit2fadf4ba6f411c0b74d5d443fb01d6380dc34f10 (patch)
parent2bfe5e16a0ba8198d9a77d6e36c17ac5daed7705 (diff)
Printing location when downloaded input data checksum is different
There are many different directory trees involved in Maneage system: the top directory, the 'reproduce/' directory and its sub-directories, '.build/' (that point to a user-defined build area), and a possibly user-defined input directory. Until now, in the case of a download checksum failure, it was not immediately obvious [1] to the user *where* the file with a failed checksum is. To clarify to the user *where* the suspicious file is now located, this commit adds a line to 'reproduce/analysis/make/download.mk' to print out this full path location: '$$unchecked' along with the expected and calculated checksums. [1] Euphemism for me spending lots of time debugging and being confused.
1 files changed, 1 insertions, 0 deletions
diff --git a/reproduce/analysis/make/download.mk b/reproduce/analysis/make/download.mk
index fb3f523..0eb28ff 100644
--- a/reproduce/analysis/make/download.mk
+++ b/reproduce/analysis/make/download.mk
@@ -88,6 +88,7 @@ $(inputdatasets): $(indir)/%.fits: | $(indir) $(lockdir)
echo; echo;
echo "Wrong MD5 checksum for input file '$$localname':"
+ echo " File location: $$unchecked"; \
echo " Expected MD5 checksum: $$mdf"; \
echo " Calculated MD5 checksum: $$sum"; \
echo; exit 1