diff options
author | Mohammad Akhlaghi <mohammad@akhlaghi.org> | 2020-04-05 21:25:48 +0100 |
---|---|---|
committer | Mohammad Akhlaghi <mohammad@akhlaghi.org> | 2020-04-05 21:31:38 +0100 |
commit | d17c12058c074855587e31eac0f064a856336ba0 (patch) | |
tree | 0fef8fc53a3fc2cc2bbf272291a3394dbdd1618c /reproduce/analysis | |
parent | aa3ba69f395a86a1acafe7e52a803d0a3af6d6ef (diff) |
Astropy now depending on the Expat library to fix internal conflict
Until now, Astropy was instructed to build its own internal copy of the
Expat library. However, with the recent commits before, Maneage now
includes an installation of Expat and Astropy can't keep the two (its
internal version and the project's version) separate, so they conflict and
don't let Astropy get built.
When trying to build Manage (the actual project, not this paper) after
applying the commits before there, Raul discovered this problem.
With this commit, the problem is fixed by setting the Expat library as an
explicit dependency of Astropy and asking Astropy to ignore its internal
copy.
While doing this, I recognized that it is much easier and elegant to add
steps in various stages of the `pybuild' function through hooks instead of
variables. So the fifth argument of the `pybuild' function was removed and
now it actually checks if hooks are defined as functions and if so, they
will be called.
The `pyhook_after' function was also implemented in the installation of
`pybind11' (which needed it, given that the 5th argument of `pybuild' was
removed) and after doing a test-build, I noticed that two lines were not
ending with a `\' in `boost' (a dependency of `pybind11').
Diffstat (limited to 'reproduce/analysis')
0 files changed, 0 insertions, 0 deletions