From e45ac9f074a62a0dab26e4de86e4c97458384d18 Mon Sep 17 00:00:00 2001 From: Mohammad Akhlaghi Date: Thu, 15 Feb 2018 12:06:31 +0100 Subject: Choice to build final PDF removed from LOCAL settings The previous change where we had set the building of the PDF as a local (and thus not version controlled) setting was not good, because different commits might be made without the high-level preparations for the final PDF (especially during the initial/testing phases of a research). Therefore, if the runner of the pipeline is ignorant to this, they may hit some errors in LaTeX which can be frustrating. To have a clean reproduction, it is thus necessary to have the choice of pdf-building under version control along with the rest of the pipeline. --- Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index 856e23c..ee9db57 100644 --- a/Makefile +++ b/Makefile @@ -33,7 +33,7 @@ # # Note that if you don't have LaTeX to build the PDF or generally are just # interested in the processing, you can skip create the final PDF creation -# with `BUILD-FINAL-PDF' of `reproduce/config/pipeline/LOCAL.mk'. +# with `pdf-build-final' of `reproduce/config/pipeline/pdf-build.mk'. all: reproduce/build paper.pdf @@ -82,18 +82,18 @@ include $(foreach f, initialize download paper, reproduce/src/make/$(f).mk) # top-level dependencies clearly. # # Note that if you don't want the final PDF and just want the processing -# and file outputs, you can remove the value of the `BUILD-FINAL-PDF' -# variable in `reproduce/config/LOCAL.mk'. +# and file outputs, you can remove the value of the `pdf-build-final' +# variable in `reproduce/config/pdf-build.mk'. tex/pipeline.tex: $(foreach f, initialize download, $(mtexdir)/$(f).tex) # If no PDF is requested, then just exit here. -ifeq ($(BUILD-FINAL-PDF),) +ifeq ($(pdf-build-final),) @echo @echo @echo "-----" @echo "Everything is OK until this point, but not building PDF." - @echo "To do so, give a value to the 'BUILD-FINAL-PDF' variable." - @echo "It is defined in 'reproduce/config/pipeline/LOCAL.mk'." + @echo "To do so, give a value to the 'pdf-build-final' variable." + @echo "It is defined in 'reproduce/config/pipeline/pdf-build.mk'." @echo @exit 1 endif -- cgit v1.2.1