From c2b36cc6b6c62b5f19745703c65df7cfa8b84cc4 Mon Sep 17 00:00:00 2001 From: Raul Infante-Sainz Date: Sun, 5 Apr 2020 17:03:16 +0100 Subject: Building Minizip 1.x instead of Minizip 2.x Minizip is a dependency of XLSX I/O and until now, I was just using the most recent version I found (2.9.2), but XLSX I/O is written for the Minizip 1.x series, not 2.x. Somehow it didn't cause a crash on my computer!!! I think XLSX I/O's CMake is instructed to look into system directories by default when it doesn't find the directories in the given places. And because I had installed Minizip on my operating system, it did't complain. Upon trying the build on their systems, Yahya, Raul and Zahra reported a failure in the build of XLSX I/O which was due the to the problem above (we were installing the wrong version of Minizip!). With this commit, this has been fixed by installing the 1.x series of Minizip (whish is actually installed within zlib!). This commit was original done by Mohammad Akhlaghi. --- .file-metadata | Bin 7874 -> 7946 bytes 1 file changed, 0 insertions(+), 0 deletions(-) (limited to '.file-metadata') diff --git a/.file-metadata b/.file-metadata index 9a732fa..aa6d61e 100644 Binary files a/.file-metadata and b/.file-metadata differ -- cgit v1.2.1