From ce17a364e7c74077d96f6e7573876db6666dd867 Mon Sep 17 00:00:00 2001
From: Raul Infante-Sainz <infantesainz@gmail.com>
Date: Wed, 21 Aug 2019 23:04:14 +0100
Subject: Using libgit2 implementation of libconv with the option
-DUSE_ICONV=OFF
When trying to install `libgit2' on my macOS system, it complains about
not finding `_iconv*' functions! But apparently `libgit2' has its own
implementation of `libiconv' that it uses if it can't find `libiconv' on
macOS. So, the solution to this problem was to add `-DUSE_ICONV=OFF' to
the configuration options of `libgit2'.
I reported this issue that now is fixed thanks to the help of Mohammad
Akhlaghi.
---
reproduce/software/make/high-level.mk | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
(limited to 'reproduce/software')
diff --git a/reproduce/software/make/high-level.mk b/reproduce/software/make/high-level.mk
index a17e989..0120675 100644
--- a/reproduce/software/make/high-level.mk
+++ b/reproduce/software/make/high-level.mk
@@ -559,12 +559,16 @@ $(ibidir)/yaml: $(tdir)/yaml-$(yaml-version).tar.gz
# libraries at runtime can be extremely problematic.". This is a major
# problem we have been having so far with Mac systems:
# https://libgit2.org/docs/guides/build-and-link
+# On macOS system, `libgit2' complains about not finding `_iconv*'
+# functions! But apparently `libgit2' has its own implementation of libiconv
+# that it uses if it can't find libiconv on macOS. So, to fix this problem
+# it is necessary to use the option `-DUSE_ICONV=OFF` in the configure step.
$(ibidir)/libgit2: $(tdir)/libgit2-$(libgit2-version).tar.gz \
$(ibidir)/cmake \
$(ibidir)/curl
$(call cbuild, $<, libgit2-$(libgit2-version), static, \
-DUSE_SSH=OFF -DBUILD_CLAR=OFF \
- -DTHREADSAFE=ON ) \
+ -DTHREADSAFE=ON -DUSE_ICONV=OFF ) \
&& if [ x$(on_mac_os) = xyes ]; then \
install_name_tool -id $(ildir)/libgit2.28.dylib \
$(ildir)/libgit2.28.dylib; \
--
cgit v1.2.1