From 6727f84b6d10fe77981b3e8117f436ec1039f643 Mon Sep 17 00:00:00 2001
From: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Date: Mon, 7 Sep 2020 19:42:03 +0100
Subject: Software installation: removed IFS statements in pre-make-build.sh

Until a recent commit, the IFS='"' was added at the start of the variables
in this shell script and as a result, the SPACE character wasn't being used
as a delimiter. This caused a major problem when downloading the tarballs
(all the backup servers were considered as the top link).

With this commit we removed these 'IFS' statements). Because we now check
for the existance of meta-characters in the build directory name, there is
no more problem, and also generally both the calling command and
internally, we have double-qutations around the variable names. So removal
of IFS will not affect the result in this scenario.

This bug was found by Mohammadreza Khellat.
---
 reproduce/software/shell/pre-make-build.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'reproduce/software')

diff --git a/reproduce/software/shell/pre-make-build.sh b/reproduce/software/shell/pre-make-build.sh
index a18966f..f11e6e6 100755
--- a/reproduce/software/shell/pre-make-build.sh
+++ b/reproduce/software/shell/pre-make-build.sh
@@ -31,10 +31,10 @@ set -e
 
 
 # Input arguments (the 'IFS's are to allow space in the name).
-IFS='"' bdir="$1"
-IFS='"' ddir="$2"
-IFS='"' downloader="$3"
-IFS='"' user_backup_urls="$4"
+bdir="$1"
+ddir="$2"
+downloader="$3"
+user_backup_urls="$4"
 
 
 
-- 
cgit v1.2.1