From c2b36cc6b6c62b5f19745703c65df7cfa8b84cc4 Mon Sep 17 00:00:00 2001 From: Raul Infante-Sainz Date: Sun, 5 Apr 2020 17:03:16 +0100 Subject: Building Minizip 1.x instead of Minizip 2.x Minizip is a dependency of XLSX I/O and until now, I was just using the most recent version I found (2.9.2), but XLSX I/O is written for the Minizip 1.x series, not 2.x. Somehow it didn't cause a crash on my computer!!! I think XLSX I/O's CMake is instructed to look into system directories by default when it doesn't find the directories in the given places. And because I had installed Minizip on my operating system, it did't complain. Upon trying the build on their systems, Yahya, Raul and Zahra reported a failure in the build of XLSX I/O which was due the to the problem above (we were installing the wrong version of Minizip!). With this commit, this has been fixed by installing the 1.x series of Minizip (whish is actually installed within zlib!). This commit was original done by Mohammad Akhlaghi. --- reproduce/software/config/installation/versions.conf | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'reproduce/software/config/installation/versions.conf') diff --git a/reproduce/software/config/installation/versions.conf b/reproduce/software/config/installation/versions.conf index 592d931..39642d4 100644 --- a/reproduce/software/config/installation/versions.conf +++ b/reproduce/software/config/installation/versions.conf @@ -107,7 +107,6 @@ libpng-version = 1.6.37 libtiff-version = 4.0.10 libtirpc-version = 1.1.4 libxml2-version = 2.9.9 -minizip-version = 2.9.2 missfits-version = 2.8.0 openblas-version = 0.3.5 openmpi-version = 4.0.1 @@ -216,3 +215,7 @@ lapack-version = 3.8.0 libgit2-version = 0.28.2 netpbm-version = 10.86.99 wcslib-version = 6.4 + +# Minizip is installed as a part of `zlib', and they have the same version. +zlib-version = 1.2.11 +minizip-version = $(zlib-version) -- cgit v1.2.1