aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorLines
2020-04-15Merged Raul's correction in the acknowledgmentsMohammad Akhlaghi-0/+0
I had also done this in the main branch, but I noticed this commit later!
2020-04-15Commented the note to DSJ editors and refereesMohammad Akhlaghi-2/+2
This was only relevant for the submitted version, so I am committing it until the next submission.
2020-04-15Minor typo correctionsMohammad Akhlaghi-12/+11
After the submission and reading through the text another time I found some typo corrections and fixed them. Also now that David is an author, I removed him from the people to acknowledge (David brought this up himself, thanks David ;-)).
2020-04-14Removed David from Acknowledgments because he is a co-authorRaul Infante-Sainz-1/+1
Since David is a co-author of the paper, I have removed him from the Acknowledgments paragraph.
2020-04-14Added note with link to paper's distribution tarballMohammad Akhlaghi-0/+4
Since the journal doesn't accept supplementary files during initial submission, I have put this link on the PDF for the referee and editors to access if they want. Also the `tex/img' file was added to the distribution tarball.
2020-04-14Corrected package distribution step and not including BibLaTeX packagesMohammad Akhlaghi-3/+6
I was using some special Bash feature before to ignore the distribution directory itself when copying the files, but that had some problems, so I just used a simple for loop over a `find' command to ignore it. Also, for now, we don't need BibLaTeX sources in the project (that is primarily for arXiv), so to help the referee see a more cleaner contents of this supplement file.
2020-04-14Imported David's corrections into the main paperMohammad Akhlaghi-202/+213
Thanks David ;-)! I tried to implement as many as I could. For the time being, I just removed teh `~' between "Section" and its number, and removed the italics on software names. Let's see what the journal editors say about it. Otherwise, most of the suggestions were very good and indeed made the text much better to read.
2020-04-14Some corrections to help make the text more clearDavid Valls-Gabaud-261/+261
David submitted these comments by email, I (Mohammad) am committing it into the project.
2020-04-14Further text shrink, added Competing interest and Author contributionsMohammad Akhlaghi-76/+113
To make the text easier to read and further comply with the author guideline, the text was shrank a little more and the two final sections were also added on "Competing interest" and "Author contributions". I also found the CODATA logo on Wikipedia in SVG format (vector graphics), so I replaced the previous pixelated PNG format with the PDF (converted from SVG).
2020-04-14Addressed points raised by Raul in previous commitMohammad Akhlaghi-5/+2
I removed the part emphasizing one journal, but about the comment at the end of the conclusion (to say some negative things): we have already done that in the discussion, mentioning the caveats ;-). But you are right, we should summarize the caveats is well.
2020-04-14Minor typos fixed up to Section 6: DiscussionRaul Infante-Sainz-21/+22
With this commit, minor typos have been fixed from Section 4 to 6. The majority of them are minor corrections (typos/spelling). I added just a couple of comments/suggestions in red. If you think they are necessary try to fit with the latest modifications. If not, just ignore them. Really nice paper, congratulations to all contributors!!
2020-04-14Minor typos fixed up to Section 3: PrinciplesRaul Infante-Sainz-16/+17
With this commit, just minor typos have been fixed (I am rushing over the text since we are out of time!). There are also a suggestion in order to remove a couple of phrases to try to be more aseptic when comparing with another project. But there is only an idea, take it or not as you consider.
2020-04-14Added first summarized draft of discussion and conclusionsMohammad Akhlaghi-16/+31
A first draft for these was added and will probably become much better in the next few iterations.
2020-04-14Edited/shortened the main body, first draft of summarized discussionMohammad Akhlaghi-267/+188
I went through the whole paper and tried to decrease its size even futher, also a first draft of the summarized discussion has been added.
2020-04-13Installation year removed from TeXLive installationMohammad Akhlaghi-23/+22
TeXLive recently transitioned from its 2019 version to its 2020 version thanks to Elham Saremi's trial of the this project. The fact that traditionally Maneage installs all TeXLive packages in a per-year directory is very annoying and required an update in the core Maneage system every year. So I suddently recognized that we can fix this by setting a different name for the directory holding the release year. This has been implemented with this commit. I have also done this change in the main Maneage branch for other projects to also benefit from this correction.
2020-04-13Configure (TeXLive): year correction also in high-level packagesMohammad Akhlaghi-1/+1
In the previous commit, I removed the year from the basic installation of TeXLive packages, but I forgot to correct this in the high-level TeXLive packages! This is corrected with this commit.
2020-04-13Configure (TeXLive): Year of distribution no longer in directoryMohammad Akhlaghi-13/+11
It is this time of year again: TeXLive has transitioned to its 2020 release and the year is imprinted into the installation directory of TeXLive. Until now, we have had to manually change this year and it caused complications and was very annoying. With this commit, the explicit year has been removed from TeXLive's installation and we now simply put a `maneage' instead of the year. I tried this on another system and it worked nicely. Until the time that we can fully install LaTeX packages from source tarballs, this is the best thing we could do for now.
2020-04-13Implemented Roberto's raised points in the paper's sourceMohammad Akhlaghi-24/+20
Thanks Roberto, they are now implemented.
2020-04-13Minor corrections and thoughtsRoberto Baena Gallé-99/+101
I corrected bugs, typos, double words, and punctuations along the whole text. I do some comments which are always highlighted with \hl{this is my comment}, so you can identify them easily in the pdf. If you want to remove, then you can do it easily with Ctrl+R since I think you never used \hl. Finally, I added my name as coauthor but, please, feel free to remove it if you want. Note from Mohammad: since there were two other suggested commits before this that were already merged, I rembased Roberto's commits and fixed a few minor conflicts.
2020-04-13Imported Pedram's corrections, no conflictsMohammad Akhlaghi-8/+8
There weren't any conflicts in this merge.
2020-04-13Added short line to inform that there are tutorialsRaul Infante-Sainz-0/+1
With this commit, a short line telling that Maneage has tutorials showing the workflow in a practical way has been added. Because of we are near to the limit of words, I have added just a very short line. The sentence does not specify any file name since the tutorial(s) is not included (it will be in a near future).
2020-04-13Adding Julia to acknowledgments for creating the logoRaul Infante-Sainz-0/+1
With this commit, I have included a small line to recognize Julia Aguilar-Cabello as the designer of the Maneage's logo.
2020-04-13Fix typosPedram Ashofteh Ardakani-8/+8
2020-04-13Full existing contents summaried, only discussion to goMohammad Akhlaghi-33/+458
The contents until two commits ago when I started to summarize the paper are now in a new and shorter format: previously the discussion started on page 25, but now it starts on page 17. It is still a little longer than 8000 words, but not as significantly as before. I will add the discussion and also try to summarize it futher before submission.
2020-04-12First draft of first three sections of shortened paper are doneMohammad Akhlaghi-0/+418
As described in the previous commit, we had to shorten the paper to roughly 8000 words (which is significant decrease!). With this commit, I am committing the current version of the summarized paper, where the introduction, defintions and principles have now been summarized. I am now summarizing the rest (describing Maneage and the discussion).
2020-04-12Configure (numpy): added --std=c99 to CFLAGS to fix errorMohammad Akhlaghi-0/+1
Elham Saremi recently reported the following errors when building Numpy in numpy/core/src/npysort/radixsort.c.src: "error: 'for' loop initial declarations are only allowed in C99 or C11 mode". After some searching, I found Issue 14147[1] on Numpy's main repository about the same problem. As described there, apparently Numpy needs C99 compiler, but doesn't check for it or set it manually (for some strange reason, leaving it to the packagers to check if they want!!!). Any way, after a check with Elham, we were able to fix it by adding the `--std=c99' to CFLAGS of Numpy's build and with this commit, it is now being implemented in the core Maneage to not cause a problem in any other project. [1] https://github.com/numpy/numpy/issues/14147
2020-04-10Renamed initial paper to paper-long.tex, to write shorter new versionMohammad Akhlaghi-0/+0
We just recently recognied that the final paper should not be longer than 8000 words. The easiest way was just to start a new `paper.tex' and bring in parts from the original/long version. We can use all the hard work that went into writing the long paper later (possibly in a manual for Maneage). So I don't want to suddenly distroy its history at this point. To let Git know about renaming the original `paper.tex' to `tex/src/paper-long.tex', I am making this commit. This commit doesn't have any `paper.tex' and only records the fact that it has been renamed. In the next commit, I'll re-create `paper.tex' which will host the short/final version. But thanks to this commit, if we later make any changes to long version, Git will know that it was originally the main `paper.tex'.
2020-04-10Acknowledged the help of Pedram, Zahra and SurenaMohammad Akhlaghi-0/+1
Thank you very much guys :-).
2020-04-10Fix spelling errors, suggest alternative wordsPedram Ashofteh Ardakani-135/+135
I tried to get all the words I knew. Some may be correct in different conventions. It definitely needs a second or third review for spell checking. Suggested some additional formatting, including but not limited to using the LaTeX \textsuperscript{} command for stating dates. Also, some unfamiliar rare words that finished with `-able` or `-ability` may need to be changed. Finding better alternatives to better simplify and ease the `readabiliy` ;-) of the paper - I see it's hard not to use them actually. It has got me wondering what better alternatives are available? We'll find out.
2020-04-10Suggest minor changes in the abstractPedram Ashofteh Ardakani-8/+9
to shorten some sentences, fix some spelling/typos, and further simplify some parts. I can see that there are some spelling errors in the rest of the paper. They will be taken care of in the next commit.
2020-04-10Imported Raul's corrections to the paper, minor conflict fixedMohammad Akhlaghi-50/+55
There was only a small conflict in the abstract with Zahra's corrections and that has been fixed.
2020-04-10Minor corrections based on Zahra's suggestionsMohammad Akhlaghi-7/+9
A parenthesis was added to the abstract to hightlight the importance of data lineage for reproducibility. Also, the definitions that Zahra had given for reproducibility were added as comments above the part on defining reproducibility. We'll later decide how to blend them in, if possible.
2020-04-09Minor typos and spelling corrections in Definitions, some notes addedRaul Infante-Sainz-24/+25
With this commit, I have corrected several minor typos in Section 2 (Definitions). I have also put a couple of notes for modify or ignore some phrases.
2020-04-09Minor typos and spelling corrections in IntroductionRaul Infante-Sainz-17/+17
With this commit, minor typos have been corrected in the Introduction section. The majority of them are just small corrections, others are in order to not use contractions ("did not" instead of "didn't" and so on). Other modifications have been added with the aim of remove some small portion of the phrases to make it more focused.
2020-04-09Trying to make the Abstract shorter, keywords sorted alphabeticallyRaul Infante-Sainz-11/+9
With this commit, I have tried to make the Abstract a bit shorter. I think it was too long considering that there are plenty of space in the paper to describe some of the points that were noticed in the abstract. The main point is just to try to be atractive to the reader being focused to the main points. In any case I think there are room for improving it. The keywords have also been sorted alphabetically.
2020-04-09Adding Raul as co-author of the paperRaul Infante-Sainz-1/+2
With this commit, I have added my name as co-author of the paper. Since my affiliation is the same as Mohammad's affiliations, I did not have to add any additional line for that.
2020-04-08Reproducibility in the abstractzahra sharbaf-2/+7
Because one of the most important properties of Manaege is reproducibility. I think is it better to say something about it in the abstract, like the thing that you do in your speech. With this commit, I noted something about it in the abstract.
2020-04-06Astropy now depending on the Expat library to fix internal conflictRaul Infante-Sainz-10/+26
Until now, Astropy was instructed to build its own internal copy of the Expat library. However, with the recent commits before, Maneage now includes an installation of Expat and Astropy can't keep the two (its internal version and the project's version) separate, so they conflict and don't let Astropy get built. With this commit, the problem is fixed by setting the Expat library as an explicit dependency of Astropy and asking Astropy to ignore its internal copy. While doing this, I recognized that it is much easier and elegant to add steps in various stages of the `pybuild' function through hooks instead of variables. So the fifth argument of the `pybuild' function was removed and now it actually checks if hooks are defined as functions and if so, they will be called. The `pyhook_after' function was also implemented in the installation of `pybind11' (which needed it, given that the 5th argument of `pybuild' was removed) and after doing a test-build, I noticed that two lines were not ending with a `\' in `boost' (a dependency of `pybind11'). Commit written originally by Mohammad Akghlaghi
2020-04-06Corrected typo in the definition of pybuildMohammad Akhlaghi-1/+1
Raul noticed this during the build: I had mistakenly put an extra `&&' at the start of the line where the line before ended with a `;'.
2020-04-05Astropy now depending on the Expat library to fix internal conflictMohammad Akhlaghi-9/+25
Until now, Astropy was instructed to build its own internal copy of the Expat library. However, with the recent commits before, Maneage now includes an installation of Expat and Astropy can't keep the two (its internal version and the project's version) separate, so they conflict and don't let Astropy get built. When trying to build Manage (the actual project, not this paper) after applying the commits before there, Raul discovered this problem. With this commit, the problem is fixed by setting the Expat library as an explicit dependency of Astropy and asking Astropy to ignore its internal copy. While doing this, I recognized that it is much easier and elegant to add steps in various stages of the `pybuild' function through hooks instead of variables. So the fifth argument of the `pybuild' function was removed and now it actually checks if hooks are defined as functions and if so, they will be called. The `pyhook_after' function was also implemented in the installation of `pybind11' (which needed it, given that the 5th argument of `pybuild' was removed) and after doing a test-build, I noticed that two lines were not ending with a `\' in `boost' (a dependency of `pybind11').
2020-04-05Commenting version numbers with an underscore for LaTeXRaul Infante-Sainz-1/+3
Until now we would simply return the version numbers as they were written into the separate files and situations can happen where the version numbers contain an underscore (`_'). However, this character is a methematical character in LaTeX, causing LaTeX to complain and abort. With this commit, a step has been added at the end of the configure script to convert any possible `_' to `\_'. Once it is commented (a backslash is put behind it), the underscore will be printed as it is in the final PDF. This commit was originally written by Mohammad Akhlaghi
2020-04-05The build of M4 and XLSX I/O on macOS has been fixedRaul Infante-Sainz-6/+37
Until now, the M4 that was built on macOS had internal problems (as discussed in #1): it would simply print `Abort trap: 6' in the output and abort. After looking at the build of Homebrew, I noticed that they apply a patch (correct one line) to fix this problem. To be able to apply that patch on macOS systems, I had fully open up the build recipe of M4 and atleast on the testing system, it was built successfully. Also, after successfully building M4, and thus Autoconf and thus Minizip, we were able to build XLSX I/O on a macOS and found out that the internal library's full address wasn't being put in the libraries and executables. With this commit, we now use macOS's `install_name_tool' to correct the positions of the two `libxlsxio_*' libraries in all its executables. This commit was originally written by Mohammad Akhlaghi
2020-04-05Including version number of Minizip in its installation targetRaul Infante-Sainz-1/+1
Until this commit, only the word `Minizip' was written into the Minizip installation target (without the version number of Minizip). With this commit, this minor bug has been fixed by using the appropiate Make variable: `$(minizip-version)'.
2020-04-05Building Minizip 1.x instead of Minizip 2.xRaul Infante-Sainz-17/+67
Minizip is a dependency of XLSX I/O and until now, I was just using the most recent version I found (2.9.2), but XLSX I/O is written for the Minizip 1.x series, not 2.x. Somehow it didn't cause a crash on my computer!!! I think XLSX I/O's CMake is instructed to look into system directories by default when it doesn't find the directories in the given places. And because I had installed Minizip on my operating system, it did't complain. Upon trying the build on their systems, Yahya, Raul and Zahra reported a failure in the build of XLSX I/O which was due the to the problem above (we were installing the wrong version of Minizip!). With this commit, this has been fixed by installing the 1.x series of Minizip (whish is actually installed within zlib!). This commit was original done by Mohammad Akhlaghi.
2020-04-04Commenting version numbers with an underscore for LaTeXMohammad Akhlaghi-1/+3
Until now we would simply return the version numbers as they were written into the separate files and situations can happen where the version numbers contain an underscore (`_'). However, this character is a methematical character in LaTeX, causing LaTeX to complain and abort. With this commit, a step has been added at the end of the configure script to convert any possible `_' to `\_'. Once it is commented (a backslash is put behind it), the underscore will be printed as it is in the final PDF.
2020-04-04The build of M4 and XLSX I/O on macOS has been fixedMohammad Akhlaghi-5/+36
Until now, the M4 that was built on macOS had internal problems (as discussed in #1): it would simply print `Abort trap: 6' in the output and abort. After looking at the build of Homebrew, I noticed that they apply a patch (correct one line) to fix this problem. To be able to apply that patch on macOS systems, I had fully open up the build recipe of M4 and atleast on the testing system, it was built successfully. Also, after successfully building M4, and thus Autoconf and thus Minizip, we were able to build XLSX I/O on a macOS and found out that the internal library's full address wasn't being put in the libraries and executables. With this commit, we now use macOS's `install_name_tool' to correct the positions of the two `libxlsxio_*' libraries in all its executables.
2020-04-04Building Minizip 1.x instead of Minizip 2.xMohammad Akhlaghi-17/+68
Minizip is a dependency of XLSX I/O and until now, I was just using the most recent version I found (2.9.2), but XLSX I/O is written for the Minizip 1.x series, not 2.x. Somehow it didn't cause a crash on my computer!!! I think XLSX I/O's CMake is instructed to look into system directories by default when it doesn't find the directories in the given places. And because I had installed Minizip on my operating system, it did't complain. Upon trying the build on their systems, Yahya, Raul and Zahra reported a failure in the build of XLSX I/O which was due the to the problem above (we were installing the wrong version of Minizip!). With this commit, this has been fixed by installing the 1.x series of Minizip (whish is actually installed within zlib!).
2020-04-03CMake updated to version 3.17.0Raul Infante-Sainz-2/+2
With this commit, CMake has been updated to its most recent version. This upgrade has been done because in the installation of XLSX I/O on macOS laptop, it crashes complaining about C compiler "not able to compile a simple test program". After a fast search, I found it could be possible to just use the most recent version of CMake to solve the problem. But it didn't work. In any case, it is good to have the most recent version of CMake included.
2020-04-02Imported recent work on Maneage, minor conflicts fixedMohammad Akhlaghi-783/+937
A few minor conflicts occurred and were fixed.
2020-04-02Rewrote abstract, better organization in publishing sectionMohammad Akhlaghi-26/+175
I hadn't updated the abstract since first writing it. With this commit, it has been updated to be more precise and generically interesting, focusing more on the principles and usability. I also greatly improved the section on publishing the workflow.